| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CADnq5_PdmvM_hNcpJRgg1DLCO9TfPJ2krHtAWFBZYLY6wZOxcA@mail.gmail.com>
Date: Mon, 7 Aug 2023 13:00:19 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Ran Sun <sunran001@...suo.com>
Cc: alexander.deucher@....com, dri-devel@...ts.freedesktop.org,
amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in smu73.h
Applied. Thanks!
On Tue, Aug 1, 2023 at 9:56 PM Ran Sun <sunran001@...suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: space prohibited before open square bracket '['
> ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
> drivers/gpu/drm/amd/pm/powerplay/inc/smu73.h | 45 ++++++++------------
> 1 file changed, 17 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/smu73.h b/drivers/gpu/drm/amd/pm/powerplay/inc/smu73.h
> index c6b12a4c00db..cf4b2c3c65bc 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/inc/smu73.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/inc/smu73.h
> @@ -37,8 +37,7 @@ enum Poly3rdOrderCoeff {
> POLY_3RD_ORDER_COUNT
> };
>
> -struct SMU7_Poly3rdOrder_Data
> -{
> +struct SMU7_Poly3rdOrder_Data {
> int32_t a;
> int32_t b;
> int32_t c;
> @@ -51,8 +50,7 @@ struct SMU7_Poly3rdOrder_Data
>
> typedef struct SMU7_Poly3rdOrder_Data SMU7_Poly3rdOrder_Data;
>
> -struct Power_Calculator_Data
> -{
> +struct Power_Calculator_Data {
> uint16_t NoLoadVoltage;
> uint16_t LoadVoltage;
> uint16_t Resistance;
> @@ -71,8 +69,7 @@ struct Power_Calculator_Data
>
> typedef struct Power_Calculator_Data PowerCalculatorData_t;
>
> -struct Gc_Cac_Weight_Data
> -{
> +struct Gc_Cac_Weight_Data {
> uint8_t index;
> uint32_t value;
> };
> @@ -187,8 +184,7 @@ typedef struct {
> #define SMU73_THERMAL_CLAMP_MODE_COUNT 8
>
>
> -struct SMU7_HystController_Data
> -{
> +struct SMU7_HystController_Data {
> uint16_t waterfall_up;
> uint16_t waterfall_down;
> uint16_t waterfall_limit;
> @@ -199,8 +195,7 @@ struct SMU7_HystController_Data
>
> typedef struct SMU7_HystController_Data SMU7_HystController_Data;
>
> -struct SMU73_PIDController
> -{
> +struct SMU73_PIDController {
> uint32_t Ki;
> int32_t LFWindupUpperLim;
> int32_t LFWindupLowerLim;
> @@ -215,8 +210,7 @@ struct SMU73_PIDController
>
> typedef struct SMU73_PIDController SMU73_PIDController;
>
> -struct SMU7_LocalDpmScoreboard
> -{
> +struct SMU7_LocalDpmScoreboard {
> uint32_t PercentageBusy;
>
> int32_t PIDError;
> @@ -261,8 +255,8 @@ struct SMU7_LocalDpmScoreboard
> uint8_t DteClampMode;
> uint8_t FpsClampMode;
>
> - uint16_t LevelResidencyCounters [SMU73_MAX_LEVELS_GRAPHICS];
> - uint16_t LevelSwitchCounters [SMU73_MAX_LEVELS_GRAPHICS];
> + uint16_t LevelResidencyCounters[SMU73_MAX_LEVELS_GRAPHICS];
> + uint16_t LevelSwitchCounters[SMU73_MAX_LEVELS_GRAPHICS];
>
> void (*TargetStateCalculator)(uint8_t);
> void (*SavedTargetStateCalculator)(uint8_t);
> @@ -315,8 +309,7 @@ typedef uint8_t (*VoltageChangeHandler_t)(uint16_t, uint8_t);
>
> typedef uint32_t SMU_VoltageLevel;
>
> -struct SMU7_VoltageScoreboard
> -{
> +struct SMU7_VoltageScoreboard {
> SMU_VoltageLevel TargetVoltage;
> uint16_t MaxVid;
> uint8_t HighestVidOffset;
> @@ -354,7 +347,7 @@ struct SMU7_VoltageScoreboard
>
> VoltageChangeHandler_t functionLinks[6];
>
> - uint16_t * VddcFollower1;
> + uint16_t *VddcFollower1;
>
> int16_t Driver_OD_RequestedVidOffset1;
> int16_t Driver_OD_RequestedVidOffset2;
> @@ -366,8 +359,7 @@ typedef struct SMU7_VoltageScoreboard SMU7_VoltageScoreboard;
> // -------------------------------------------------------------------------------------------------------------------------
> #define SMU7_MAX_PCIE_LINK_SPEEDS 3 /* 0:Gen1 1:Gen2 2:Gen3 */
>
> -struct SMU7_PCIeLinkSpeedScoreboard
> -{
> +struct SMU7_PCIeLinkSpeedScoreboard {
> uint8_t DpmEnable;
> uint8_t DpmRunning;
> uint8_t DpmForce;
> @@ -396,8 +388,7 @@ typedef struct SMU7_PCIeLinkSpeedScoreboard SMU7_PCIeLinkSpeedScoreboard;
> #define SMU7_SCALE_I 7
> #define SMU7_SCALE_R 12
>
> -struct SMU7_PowerScoreboard
> -{
> +struct SMU7_PowerScoreboard {
> uint32_t GpuPower;
>
> uint32_t VddcPower;
> @@ -436,8 +427,7 @@ typedef struct SMU7_PowerScoreboard SMU7_PowerScoreboard;
> #define SMU7_VCE_SCLK_HANDSHAKE_DISABLE 0x00020000
>
> // All 'soft registers' should be uint32_t.
> -struct SMU73_SoftRegisters
> -{
> +struct SMU73_SoftRegisters {
> uint32_t RefClockFrequency;
> uint32_t PmTimerPeriod;
> uint32_t FeatureEnables;
> @@ -493,8 +483,7 @@ struct SMU73_SoftRegisters
>
> typedef struct SMU73_SoftRegisters SMU73_SoftRegisters;
>
> -struct SMU73_Firmware_Header
> -{
> +struct SMU73_Firmware_Header {
> uint32_t Digest[5];
> uint32_t Version;
> uint32_t HeaderSize;
> @@ -708,9 +697,9 @@ typedef struct VFT_CELL_t VFT_CELL_t;
>
> struct VFT_TABLE_t {
> VFT_CELL_t Cell[TEMP_RANGE_MAXSTEPS][NUM_VFT_COLUMNS];
> - uint16_t AvfsGbv [NUM_VFT_COLUMNS];
> - uint16_t BtcGbv [NUM_VFT_COLUMNS];
> - uint16_t Temperature [TEMP_RANGE_MAXSTEPS];
> + uint16_t AvfsGbv[NUM_VFT_COLUMNS];
> + uint16_t BtcGbv[NUM_VFT_COLUMNS];
> + uint16_t Temperature[TEMP_RANGE_MAXSTEPS];
>
> uint8_t NumTemperatureSteps;
> uint8_t padding[3];
> --
> 2.17.1
>
Powered by blists - more mailing lists