[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_Nk_kyK2SViK3cPKvkXQOgsW+tGCwz+4uFveCUBk0BjkQ@mail.gmail.com>
Date: Mon, 7 Aug 2023 13:17:22 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Ran Sun <sunran001@...suo.com>
Cc: alexander.deucher@....com, dri-devel@...ts.freedesktop.org,
amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: Clean up errors in amdgpu_psp.h
Applied. Thanks!
On Wed, Aug 2, 2023 at 2:40 AM Ran Sun <sunran001@...suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: open brace '{' following enum go on the same line
>
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h
> index c3203de4a007..feef988bf0c1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h
> @@ -78,8 +78,7 @@ enum psp_bootloader_cmd {
> PSP_BL__LOAD_TOS_SPL_TABLE = 0x10000000,
> };
>
> -enum psp_ring_type
> -{
> +enum psp_ring_type {
> PSP_RING_TYPE__INVALID = 0,
> /*
> * These values map to the way the PSP kernel identifies the
> @@ -89,8 +88,7 @@ enum psp_ring_type
> PSP_RING_TYPE__KM = 2 /* Kernel mode ring (formerly called GPCOM) */
> };
>
> -struct psp_ring
> -{
> +struct psp_ring {
> enum psp_ring_type ring_type;
> struct psp_gfx_rb_frame *ring_mem;
> uint64_t ring_mem_mc_addr;
> @@ -107,8 +105,7 @@ enum psp_reg_prog_id {
> PSP_REG_LAST
> };
>
> -struct psp_funcs
> -{
> +struct psp_funcs {
> int (*init_microcode)(struct psp_context *psp);
> int (*bootloader_load_kdb)(struct psp_context *psp);
> int (*bootloader_load_spl)(struct psp_context *psp);
> @@ -307,8 +304,7 @@ struct psp_runtime_scpm_entry {
> enum psp_runtime_scpm_authentication scpm_status;
> };
>
> -struct psp_context
> -{
> +struct psp_context {
> struct amdgpu_device *adev;
> struct psp_ring km_ring;
> struct psp_gfx_cmd_resp *cmd;
> --
> 2.17.1
>
Powered by blists - more mailing lists