linux-kernel - Re: [PATCH] drm/amdgpu: Clean up errors in vcn_v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_PYnyF4JB5vWYydcWziaAyULWmxayZN6q+-iYnCBohO+A@mail.gmail.com>
Date:   Mon, 7 Aug 2023 13:31:37 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Ran Sun <sunran001@...suo.com>
Cc:     alexander.deucher@....com, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: Clean up errors in vcn_v4_0.c

Applied.  Thanks!

On Wed, Aug 2, 2023 at 3:43 AM Ran Sun <sunran001@...suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> spaces required around that '==' (ctx:VxV)
> ERROR: space required before the open parenthesis '('
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> index 6089c7deba8a..ef5b16061e96 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> @@ -1139,11 +1139,11 @@ static int vcn_v4_0_start(struct amdgpu_device *adev)
>                                 if (status & 2)
>                                         break;
>                                 mdelay(10);
> -                               if (amdgpu_emu_mode==1)
> +                               if (amdgpu_emu_mode == 1)
>                                         msleep(1);
>                         }
>
> -                       if (amdgpu_emu_mode==1) {
> +                       if (amdgpu_emu_mode == 1) {
>                                 r = -1;
>                                 if (status & 2) {
>                                         r = 0;
> @@ -1959,7 +1959,7 @@ static int vcn_v4_0_set_powergating_state(void *handle, enum amd_powergating_sta
>                 return 0;
>         }
>
> -       if(state == adev->vcn.cur_state)
> +       if (state == adev->vcn.cur_state)
>                 return 0;
>
>         if (state == AMD_PG_STATE_GATE)
> @@ -1967,7 +1967,7 @@ static int vcn_v4_0_set_powergating_state(void *handle, enum amd_powergating_sta
>         else
>                 ret = vcn_v4_0_start(adev);
>
> -       if(!ret)
> +       if (!ret)
>                 adev->vcn.cur_state = state;
>
>         return ret;
> @@ -2101,8 +2101,7 @@ static const struct amd_ip_funcs vcn_v4_0_ip_funcs = {
>         .set_powergating_state = vcn_v4_0_set_powergating_state,
>  };
>
> -const struct amdgpu_ip_block_version vcn_v4_0_ip_block =
> -{
> +const struct amdgpu_ip_block_version vcn_v4_0_ip_block = {
>         .type = AMD_IP_BLOCK_TYPE_VCN,
>         .major = 4,
>         .minor = 0,
> --
> 2.17.1
>