linux-kernel - Re: [PATCH v2] cgroup/rstat: Record the cumulative per-cpu time of cgroup and its descendants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZNE6-U5zwKUguRJE@slm.duckdns.org>
Date:   Mon, 7 Aug 2023 08:42:01 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Hao Jia <jiahao.os@...edance.com>
Cc:     lizefan.x@...edance.com, hannes@...xchg.org, mkoutny@...e.com,
        songmuchun@...edance.com, muchun.song@...ux.dev,
        wuyun.abel@...edance.com, cgroups@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cgroup/rstat: Record the cumulative per-cpu time of
 cgroup and its descendants

On Mon, Aug 07, 2023 at 11:29:30AM +0800, Hao Jia wrote:
> The member variable bstat of the structure cgroup_rstat_cpu
> records the per-cpu time of the cgroup itself, but does not
> include the per-cpu time of its descendants. The per-cpu time
> including descendants is very useful for calculating the
> per-cpu usage of cgroups.
> 
> Although we can indirectly obtain the total per-cpu time
> of the cgroup and its descendants by accumulating the per-cpu
> bstat of each descendant of the cgroup. But after a child cgroup
> is removed, we will lose its bstat information. This will cause
> the cumulative value to be non-monotonic, thus affecting
> the accuracy of cgroup per-cpu usage.
> 
> So we add the subtree_bstat variable to record the total
> per-cpu time of this cgroup and its descendants, which is
> similar to "cpuacct.usage*" in cgroup v1. And this is
> also helpful for the migration from cgroup v1 to cgroup v2.
> After adding this variable, we can obtain the per-cpu time of
> cgroup and its descendants in user mode through eBPF/drgn, etc.
> And we are still trying to determine how to expose it in the
> cgroupfs interface.
> 
> Suggested-by: Tejun Heo <tj@...nel.org>
> Signed-off-by: Hao Jia <jiahao.os@...edance.com>

Applied to cgroup/for-6.6.

Thanks.

-- 
tejun