linux-kernel - Re: [PATCH 12/13] arm64: dts: ti: k3-am65: Enable TSCADC nodes at the board level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd8352a9-6ab4-dbcc-1bee-8ad76e6b3004@ti.com>
Date:   Mon, 7 Aug 2023 11:21:25 +0530
From:   Dhruva Gole <d-gole@...com>
To:     Andrew Davis <afd@...com>, Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 12/13] arm64: dts: ti: k3-am65: Enable TSCADC nodes at the
 board level

Andrew,

On 03/08/23 02:23, Andrew Davis wrote:
> TSCADC nodes defined in the top-level AM65 SoC dtsi files are incomplete
> and may not be functional unless they are extended with pinmux and/or
> device information.
> 
> Disable the TSCADC nodes in the dtsi files and only enable the ones that
> are actually pinned out on a given board.
> 
> Signed-off-by: Andrew Davis <afd@...com>
> ---
>   arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 5 +----
>   arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi            | 2 ++
>   arch/arm64/boot/dts/ti/k3-am654-base-board.dts     | 2 ++
>   3 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index 6041862d5aa75..ba1c14a54acf4 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -582,11 +582,8 @@ &mcu_spi0 {
>   	ti,pindir-d0-out-d1-in;
>   };
>   
> -&tscadc0 {
> -	status = "disabled";
> -};
> -
>   &tscadc1 {
> +	status = "okay";

The commit body says,
"Disable the TSCADC nodes in the dtsi files"

Please can we also provide some explanation on why
tscadc1 was left as okay here in a dtsi file?

>   	adc {
>   		ti,adc-channels = <0 1 2 3 4 5>;
>   	};
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> index 2c9c20a9d9179..4defde540fe0b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> @@ -112,6 +112,7 @@ tscadc0: tscadc@...00000 {
>   		dmas = <&mcu_udmap 0x7100>,
>   			<&mcu_udmap 0x7101 >;
>   		dma-names = "fifo0", "fifo1";
> +		status = "disabled";
>   
>   		adc {
>   			#io-channel-cells = <1>;
> @@ -130,6 +131,7 @@ tscadc1: tscadc@...10000 {
>   		dmas = <&mcu_udmap 0x7102>,
>   			<&mcu_udmap 0x7103>;
>   		dma-names = "fifo0", "fifo1";
> +		status = "disabled";
>   
>   		adc {
>   			#io-channel-cells = <1>;
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index 43de7c132d343..17f45a9f7b146 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -478,12 +478,14 @@ &usb0_phy {
>   };
>   
>   &tscadc0 {
> +	status = "okay";
>   	adc {
>   		ti,adc-channels = <0 1 2 3 4 5 6 7>;
>   	};
>   };
>   
>   &tscadc1 {
> +	status = "okay";
>   	adc {
>   		ti,adc-channels = <0 1 2 3 4 5 6 7>;
>   	};

-- 
Thanks and Regards,
Dhruva Gole