linux-kernel - Re: [PATCH] pinctrl: amd: Don't show `Invalid config param` errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <70896b34-ea85-45be-8287-1f3858596837@amd.com>
Date:   Mon, 7 Aug 2023 15:47:51 -0500
From:   Mario Limonciello <mario.limonciello@....com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Basavaraj.Natikar@....com, Shyam-sundar.S-k@....com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: amd: Don't show `Invalid config param` errors

On 8/7/2023 15:45, Linus Walleij wrote:
> On Mon, Aug 7, 2023 at 8:17 PM Mario Limonciello
> <mario.limonciello@....com> wrote:
>> On 7/23/2023 14:41, Linus Walleij wrote:
>>> On Mon, Jul 17, 2023 at 10:17 PM Mario Limonciello
>>> <mario.limonciello@....com> wrote:
>>>
>>>> On some systems amd_pinconf_set() is called with parameters
>>>> 0x8 (PIN_CONFIG_DRIVE_PUSH_PULL) or 0x14 (PIN_CONFIG_PERSIST_STATE)
>>>> which are not supported by pinctrl-amd.
>>>>
>>>> Don't show an err message when called with an invalid parameter,
>>>> downgrade this to debug instead.
>>>>
>>>> Cc: stable@...r.kernel.org # 6.1
>>>> Fixes: 635a750d958e1 ("pinctrl: amd: Use amd_pinconf_set() for all config options")
>>>> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
>>>
>>> Applied for nonurgent fixes.
>>>
>>
>> Just wanted to check if you'll be sending this out for -rc6.  It
>> backported to stable and a few bugs cropped up because it's noisy.
> 
> No, nonurgent means I queue it for v6.6. Fear of causing regressions
> on mainline is the reason to not send fixes unless they are urgent.
> 
> Yours,
> Linus Walleij

Understood, thanks.  I'll let reporters know to wait until 6.6 then for 
this particular fix.