[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c52b2eed-d546-4027-bfb9-f3d964f025a9@lunn.ch>
Date: Mon, 7 Aug 2023 23:48:24 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Andrew Halaney <ahalaney@...hat.com>
Cc: Bartosz Golaszewski <brgl@...ev.pl>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Alex Elder <elder@...aro.org>,
Srini Kandagatla <srinivas.kandagatla@...aro.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 1/9] arm64: dts: qcom: sa8775p: add a node for the second
serdes PHY
> That wording of "match downstream sources" is amiguous, sorry.
>
> What I meant was that:
>
> 1. This looks like a properly formatted dtsi node, follows
> conventions in the file for ordering, etc
> 2. The downstream devicetree from Qualcomm uses the same MMIO region
> same dependencies for clocks, etc. I do not have documentation
> to further review past that
O.K. This does make your reviews worthwhile.
Vendor crap gets that name for a reason. So just saying it is the same
as the vendor code is not really helpful. So i would avoid this
ambiguous statement. And your later comment on a patch which points
out real problems adds to my confidence you did a real review.
Thanks
Andrew
Powered by blists - more mailing lists