linux-kernel - Re: [PATCH] spi: dw: Set default value if reg-io-width isn't specified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <az7wvv5f42mnuuwkqzpfmwg4ngvl4jvpcfmns7d6lhzogc4qdi@ox64l6i7b44r>
Date:   Tue, 8 Aug 2023 01:57:44 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
Cc:     Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: dw: Set default value if reg-io-width isn't
 specified

On Mon, Aug 07, 2023 at 09:16:21AM +0900, Kunihiko Hayashi wrote:
> According to the dt-bindings, the default value of reg-io-width is 4.
> However, the value becomes zero when reg-io-width isn't specified.

This semantic is implied by the dw_read_io_reg() and dw_write_io_reg()
methods. It doesn't seem like that much necessary duplicating it in the
property parse procedure, if not to say - redundant.

-Serge(y)

> 
> Should set the actual value to dws->reg_io_width, considering it
> referenced.
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
> ---
>  drivers/spi/spi-dw-mmio.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
> index a963bc96c223..7eafc07ef7aa 100644
> --- a/drivers/spi/spi-dw-mmio.c
> +++ b/drivers/spi/spi-dw-mmio.c
> @@ -369,7 +369,9 @@ static int dw_spi_mmio_probe(struct platform_device *pdev)
>  
>  	dws->max_freq = clk_get_rate(dwsmmio->clk);
>  
> -	device_property_read_u32(&pdev->dev, "reg-io-width", &dws->reg_io_width);
> +	if (device_property_read_u32(&pdev->dev, "reg-io-width",
> +				     &dws->reg_io_width))
> +		dws->reg_io_width = 4;
>  
>  	num_cs = 4;
>  
> -- 
> 2.25.1
>