linux-kernel - Re: [PATCH 1/5] dma: delect redundant parameter for dma driver function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Aug 2023 15:43:07 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     Kaiwei Liu <kaiwei.liu@...soc.com>, Vinod Koul <vkoul@...nel.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        kaiwei liu <liukaiwei086@...il.com>,
        Wenming Wu <wenming.wu@...soc.com>
Subject: Re: [PATCH 1/5] dma: delect redundant parameter for dma driver
 function



On 8/7/2023 1:19 PM, Kaiwei Liu wrote:
> The parameter *sdesc in function sprd_dma_check_trans_done is not
> used, so here delect redundant parameter.
> 
> Signed-off-by: Kaiwei Liu <kaiwei.liu@...soc.com>

The subject line should be "dmaengine: sprd: xxx", and please also 
change all your following patches.

With subject line fixed, you can add:
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

> ---
>   drivers/dma/sprd-dma.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
> index 2b639adb48ba..20c3cb1ef2f5 100644
> --- a/drivers/dma/sprd-dma.c
> +++ b/drivers/dma/sprd-dma.c
> @@ -572,8 +572,7 @@ static void sprd_dma_stop(struct sprd_dma_chn *schan)
>   	schan->cur_desc = NULL;
>   }
>   
> -static bool sprd_dma_check_trans_done(struct sprd_dma_desc *sdesc,
> -				      enum sprd_dma_int_type int_type,
> +static bool sprd_dma_check_trans_done(enum sprd_dma_int_type int_type,
>   				      enum sprd_dma_req_mode req_mode)
>   {
>   	if (int_type == SPRD_DMA_NO_INT)
> @@ -619,8 +618,7 @@ static irqreturn_t dma_irq_handle(int irq, void *dev_id)
>   			vchan_cyclic_callback(&sdesc->vd);
>   		} else {
>   			/* Check if the dma request descriptor is done. */
> -			trans_done = sprd_dma_check_trans_done(sdesc, int_type,
> -							       req_type);
> +			trans_done = sprd_dma_check_trans_done(int_type, req_type);
>   			if (trans_done == true) {
>   				vchan_cookie_complete(&sdesc->vd);
>   				schan->cur_desc = NULL;