linux-kernel - Re: [PATCH V6,net-next] net: mana: Add page pool for RX buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f69bd92-a063-1934-2bd8-42a5950254a7@kernel.org>
Date:   Mon, 7 Aug 2023 10:35:05 +0200
From:   Jesper Dangaard Brouer <hawk@...nel.org>
To:     Haiyang Zhang <haiyangz@...rosoft.com>,
        linux-hyperv@...r.kernel.org, netdev@...r.kernel.org
Cc:     decui@...rosoft.com, kys@...rosoft.com, paulros@...rosoft.com,
        olaf@...fle.de, vkuznets@...hat.com, davem@...emloft.net,
        wei.liu@...nel.org, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, leon@...nel.org, longli@...rosoft.com,
        ssengar@...ux.microsoft.com, linux-rdma@...r.kernel.org,
        daniel@...earbox.net, john.fastabend@...il.com,
        bpf@...r.kernel.org, ast@...nel.org, sharmaajay@...rosoft.com,
        hawk@...nel.org, tglx@...utronix.de,
        shradhagupta@...ux.microsoft.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V6,net-next] net: mana: Add page pool for RX buffers



On 04/08/2023 22.33, Haiyang Zhang wrote:
> Add page pool for RX buffers for faster buffer cycle and reduce CPU
> usage.
> 
> The standard page pool API is used.
> 
> With iperf and 128 threads test, this patch improved the throughput
> by 12-15%, and decreased the IRQ associated CPU's usage from 99-100% to
> 10-50%.
> 
> Signed-off-by: Haiyang Zhang<haiyangz@...rosoft.com>
> Reviewed-by: Jesse Brandeburg<jesse.brandeburg@...el.com>

For the record I want to provide my ACK as page_pool maintainer:

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>

As patch was applied Sunday, my ACK will not reach the git tree
  https://git.kernel.org/netdev/net-next/c/b1d13f7a3b53

--Jesper