linux-kernel - Re: [PATCH v5 12/19] selftests/resctrl: Remove "malloc_and_init_memory" param from run_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89befd7d-f756-f462-3986-a63f4e3dba86@linux.intel.com>
Date:   Mon, 7 Aug 2023 13:21:29 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Reinette Chatre <reinette.chatre@...el.com>
cc:     Shuah Khan <skhan@...uxfoundation.org>,
        linux-kselftest@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
        Shaopeng Tan <tan.shaopeng@...fujitsu.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 12/19] selftests/resctrl: Remove "malloc_and_init_memory"
 param from run_fill_buf()

On Tue, 25 Jul 2023, Reinette Chatre wrote:

> Hi Shuah,
> 
> On 7/25/2023 7:49 AM, Shuah Khan wrote:
> > WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
> > #233: FILE: tools/testing/selftests/resctrl/resctrl_tests.c:276:
> > +        strcpy(benchmark_cmd[3], "0");
> > 
> > WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
> > #234: FILE: tools/testing/selftests/resctrl/resctrl_tests.c:277:
> > +        strcpy(benchmark_cmd[4], "");
> > 
> > total: 0 errors, 2 warnings, 142 lines checked
> > 
> > I am applying the patch set to linux-kselftest next - please fix
> > the aboe and send a patch on top of linux-kselftest next
> 
> Is strscpy() available to userspace? I found lib/strscpy_kunit.c
> that makes me think this is currently only available to kernel code.

It's not available and I've done so little userspace programming in 
the recent years (and even less string manipulation in userspace C)
I've no idea what would be the best way to replace it.

However, I've a few patches which will cleanup the benchmark command 
handling that include removal of these strcpy()s. Those changes looked 
separate enough from the rest I can send it independent of that CAT 
rewrite which would have been the next entry in my pending resctrl 
selftest patches queue.


-- 
 i.