linux-kernel - [PATCH] reset: npcm: remove unneeded call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230807105630.11638-1-aboutphysycs@gmail.com>
Date:   Mon,  7 Aug 2023 13:56:30 +0300
From:   Andrei Coardos <aboutphysycs@...il.com>
To:     linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org
Cc:     p.zabel@...gutronix.de, benjaminfair@...gle.com, yuenn@...gle.com,
        venture@...gle.com, tali.perry1@...il.com, tmaimon77@...il.com,
        avifishman70@...il.com, Andrei Coardos <aboutphysycs@...il.com>,
        Alexandru Ardelean <alex@...uggie.ro>
Subject: [PATCH] reset: npcm: remove unneeded call to platform_set_drvdata()

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
---
 drivers/reset/reset-npcm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/reset/reset-npcm.c b/drivers/reset/reset-npcm.c
index f2333506b0a6..f6c4f854f2be 100644
--- a/drivers/reset/reset-npcm.c
+++ b/drivers/reset/reset-npcm.c
@@ -394,8 +394,6 @@ static int npcm_rc_probe(struct platform_device *pdev)
 	rc->rcdev.of_reset_n_cells = 2;
 	rc->rcdev.of_xlate = npcm_reset_xlate;
 
-	platform_set_drvdata(pdev, rc);
-
 	ret = devm_reset_controller_register(&pdev->dev, &rc->rcdev);
 	if (ret) {
 		dev_err(&pdev->dev, "unable to register device\n");
-- 
2.34.1