linux-kernel - Re: [PATCH] arm64: dts: mt8195: change watchdog reset boot flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f9ed06cb-2c9b-6b82-0bb4-2189a05218a1@collabora.com>
Date:   Mon, 7 Aug 2023 14:05:37 +0300
From:   Eugen Hristev <eugen.hristev@...labora.com>
To:     Hsin-Te Yuan <yuanhsinte@...omium.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Hsin-Te Yuan <yuanhsinte@...gle.com>
Subject: Re: [PATCH] arm64: dts: mt8195: change watchdog reset boot flow

Hello Hsin-Te,

On 8/7/23 11:58, Hsin-Te Yuan wrote:
> The external output reset signal was originally disabled and sent from
> firmware. However, an unfixed bug in the firmware prevents the signal
> from being sent, causing the device to fail to boot. To fix this, enable
> external output reset signal to allow the device to reboot normally.
> 
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@...gle.com>
> ---
> 
>   arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> index 37a3e9de90ff7..5dc4214e1840b 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> @@ -1147,6 +1147,10 @@ &uart0 {
>   	status = "okay";
>   };
>   
> +&watchdog {
> +	/delete-property/ mediatek,disable-extrst;
> +};
> +

Does this affect only the mt8195-cherry or all mt8195 boards ?

Judging by this commit , I think only mt8195-cherry, but your commit 
message somehow suggests otherwise.

Eugen

>   &xhci0 {
>   	status = "okay";
>