linux-kernel - Re: [PATCH] reset: uniphier-glue: remove unneeded call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH3L5QrySJPGT9ZYkV1nC2x+gPKMj7JEbZoCLjzkQjEd2oRjcQ@mail.gmail.com>
Date:   Mon, 7 Aug 2023 14:58:54 +0300
From:   Alexandru Ardelean <alex@...uggie.ro>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        mhiramat@...nel.org, hayashi.kunihiko@...ionext.com,
        p.zabel@...gutronix.de
Subject: Re: [PATCH] reset: uniphier-glue: remove unneeded call to platform_set_drvdata()

On Mon, Aug 7, 2023 at 2:27 PM Andrei Coardos <aboutphysycs@...il.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>

> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
>  drivers/reset/reset-uniphier-glue.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/reset/reset-uniphier-glue.c b/drivers/reset/reset-uniphier-glue.c
> index 15abac9fc72c..df41b75786ad 100644
> --- a/drivers/reset/reset-uniphier-glue.c
> +++ b/drivers/reset/reset-uniphier-glue.c
> @@ -99,8 +99,6 @@ static int uniphier_glue_reset_probe(struct platform_device *pdev)
>         priv->rdata.rcdev.of_node = dev->of_node;
>         priv->rdata.active_low = true;
>
> -       platform_set_drvdata(pdev, priv);
> -
>         return devm_reset_controller_register(dev, &priv->rdata.rcdev);
>  }
>
> --
> 2.34.1
>