linux-kernel - Re: [PATCH] spi: gxp: removed unneeded call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c867e685-7665-420b-9478-bce6eb067463@sirena.org.uk>
Date:   Mon, 7 Aug 2023 14:27:33 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
        nick.hawkins@....com, verdun@....com, alex@...uggie.ro
Subject: Re: [PATCH] spi: gxp: removed unneeded call to platform_set_drvdata()

On Mon, Aug 07, 2023 at 04:02:17PM +0300, Andrei Coardos wrote:

> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.

That isn't enough of a check here - people can still reference the
driver data without going through the accessor function.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)