linux-kernel - Re: [PATCH v1 3/3] EDAC/amd64: Add support for AMD Family 1Ah Models 00h-1Fh and 40h-4Fh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36bff484-f41a-4eed-bcd6-a96539b905b8@amd.com>
Date:   Mon, 7 Aug 2023 09:48:07 -0400
From:   Yazen Ghannam <yazen.ghannam@....com>
To:     "Limonciello, Mario" <mario.limonciello@....com>,
        Avadhut Naik <avadhut.naik@....com>, bp@...en8.de,
        linux@...ck-us.net, x86@...nel.org, linux-hwmon@...r.kernel.org,
        linux-edac@...r.kernel.org
Cc:     yazen.ghannam@....com, linux-kernel@...r.kernel.org,
        avadnaik@....com
Subject: Re: [PATCH v1 3/3] EDAC/amd64: Add support for AMD Family 1Ah Models
 00h-1Fh and 40h-4Fh

On 8/4/2023 12:03 PM, Limonciello, Mario wrote:
> 
> 
> On 8/3/2023 7:25 PM, Yazen Ghannam wrote:
>> On 7/6/2023 1:13 PM, Avadhut Naik wrote:
>>> From: Avadhut Naik <Avadhut.Naik@....com>
>>>
>>> Add the necessary support in the module for AMD's new Family 1Ah-based
>>> models 00h-1Fh and 40h-4Fh.
>>>
>>
>> The first patch in this set adds PCI IDs for models starting at 20h. 
>> And this patch adds support for models 40h-4Fh.
>>
>> Can you please elaborate on the discrepancy?
>>
>> Thanks,
>> Yazen
>>
> 
> Model 40h-4fh shares some of the same design as some other platforms.
> 
> The root port ID PCI_DEVICE_ID_AMD_19H_M60H_ROOT and DF_F3 ID 
> PCI_DEVICE_ID_AMD_19H_M60H_DF_F3 covers it.

That's fair. Can these details be included in the commit message?

Thanks,
Yazen