linux-kernel - Re: [PATCH -next] wifi: ath5k: Remove redundant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be5aa2bf-17fb-d241-25b1-c06b27fdcf89@quicinc.com>
Date:   Mon, 7 Aug 2023 07:02:35 -0700
From:   Jeff Johnson <quic_jjohnson@...cinc.com>
To:     Ruan Jinjie <ruanjinjie@...wei.com>, <jirislaby@...nel.org>,
        <mickflemm@...il.com>, <mcgrof@...nel.org>, <kvalo@...nel.org>,
        <linux-wireless@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] wifi: ath5k: Remove redundant dev_err()

On 7/26/2023 10:12 AM, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as it is
> going to display an appropriate error message in case of a failure.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>

Reviewed-by: Jeff Johnson <quic_jjohnson@...cinc.com>

> ---
>   drivers/net/wireless/ath/ath5k/ahb.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> index 28a1e5eff204..08bd5d3b00f1 100644
> --- a/drivers/net/wireless/ath/ath5k/ahb.c
> +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> @@ -115,7 +115,6 @@ static int ath_ahb_probe(struct platform_device *pdev)
>   
>   	irq = platform_get_irq(pdev, 0);
>   	if (irq < 0) {
> -		dev_err(&pdev->dev, "no IRQ resource found: %d\n", irq);
>   		ret = irq;
>   		goto err_iounmap;
>   	}