linux-kernel - Re: [PATCH v4 1/3] iio: Add IIO_DELTA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cef38375a5259e7df0111821b112341ed670e682.camel@gmail.com>
Date:   Mon, 07 Aug 2023 16:26:17 +0200
From:   Nuno Sá <noname.nuno@...il.com>
To:     Ramona Bolboaca <ramona.bolboaca@...log.com>, jic23@...nel.org,
        nuno.sa@...log.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] iio: Add IIO_DELTA_ANGL channel type

On Mon, 2023-08-07 at 14:12 +0300, Ramona Bolboaca wrote:
> The delta angle is defined as a piece-wise integration of angular
> velocity data. The delta angle represents the amount of
> angular displacement between two consecutive measurements and it
> is measured in radians.
> 
> In order to track the total angular displacement during a desired
> period of time, simply sum-up the delta angle samples acquired
> during that time.
> 
> IIO currently does not offer a suitable channel type for this
> type of measurements hence this patch adds it.
> 
> Signed-off-by: Ramona Bolboaca <ramona.bolboaca@...log.com>
> ---
>  Documentation/ABI/testing/sysfs-bus-iio | 14 ++++++++++++++
>  drivers/iio/industrialio-core.c         |  1 +
>  include/uapi/linux/iio/types.h          |  1 +
>  tools/iio/iio_event_monitor.c           |  2 ++
>  4 files changed, 18 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio
> b/Documentation/ABI/testing/sysfs-bus-iio
> index a2854dc9a839..32675fa7dc6f 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -279,6 +279,20 @@ Description:
>                 but should match other such assignments on device).
>                 Units after application of scale and offset are m/s^2.
>  
> +What:          /sys/bus/iio/devices/iio:deviceX/in_deltaangl_x_raw
> +What:          /sys/bus/iio/devices/iio:deviceX/in_deltaangl_y_raw
> +What:          /sys/bus/iio/devices/iio:deviceX/in_deltaangl_z_raw

I wonder if we also need to add these to the scan element specific bits? From a
quick look, it seems not all supported attributes are in there so I'm not sure
what's the policy in here :)


- Nuno Sá