[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230807163340.1ebe1e15@xps-13>
Date: Mon, 7 Aug 2023 16:33:40 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Michael Walle <michael@...le.cc>
Cc: Michael Walle <mwalle@...nel.org>,
Tudor Ambarus <tudor.ambarus@...aro.org>,
Pratyush Yadav <pratyush@...nel.org>,
Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>,
linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 06/41] mtd: spi-nor: default page_size to 256 bytes
Hi Michael,
michael@...le.cc wrote on Mon, 07 Aug 2023 16:29:38 +0200:
> Hi Miquel,
>
> >> + params->page_size = info->page_size ?: SPI_NOR_DEFAULT_PAGE_SIZE;
> >
> > Would you mind clarifying this? It does not look right, while
> > perhaps it is. But TBH, I have no idea what params->page_size will be
> > after this assignment.
>
> It's info->page_size, it's a shortcut [1].
Elvis operator :')
> I'm not the first one using it (in fact I was explicitly asked to use it,
> e.g. in gpio subsys):
>
> $ grep -r "?:" **/*.c |wc -l
> 1268
Okay then... I didn't know this was encouraged.
> -michael
>
> [1] https://en.wikipedia.org/wiki/Elvis_operator
Thanks,
Miquèl
Powered by blists - more mailing lists