linux-kernel - Re: [PATCH] loongarch: Remove spurious "source drivers/firmware/Kconfig"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2023 15:16:17 +0800
From:   Huacai Chen <chenhuacai@...nel.org>
To:     Xi Ruoyao <xry111@...111.site>
Cc:     loongarch@...ts.linux.dev, WANG Xuerui <kernel@...0n.name>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] loongarch: Remove spurious "source drivers/firmware/Kconfig"

Hi, Ruoyao,

I think the title should be "LoongArch: Remove redundant "source
drivers/firmware/Kconfig""?

Huacai

On Tue, Aug 8, 2023 at 11:49 AM Xi Ruoyao <xry111@...111.site> wrote:
>
> In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all ports so
> there is no need to source it in the port-specific Kconfig file.  And
> sourcing it here also caused the "Firmware Drivers" menu appeared two
> times: once in the "Device Drivers" menu, another time in the toplevel
> menu.  This was really puzzling.
>
> Signed-off-by: Xi Ruoyao <xry111@...111.site>
> ---
>  arch/loongarch/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index e71d5bf2cee0..465759f6b0ed 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -662,5 +662,3 @@ source "kernel/power/Kconfig"
>  source "drivers/acpi/Kconfig"
>
>  endmenu
> -
> -source "drivers/firmware/Kconfig"
> --
> 2.41.0
>