linux-kernel - Re: [patch V3 45/60] x86/apic: Sanitize APID ID range validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87msz1l5yk.ffs@tglx>
Date:   Tue, 08 Aug 2023 20:55:15 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Qiuxu Zhuo <qiuxu.zhuo@...el.com>
Cc:     andrew.cooper3@...rix.com, arjan@...ux.intel.com, jgross@...e.com,
        linux-kernel@...r.kernel.org, mikelley@...rosoft.com,
        pbonzini@...hat.com, peter@...esztesschmidt.de,
        peterz@...radead.org, thomas.lendacky@....com, wei.liu@...nel.org,
        x86@...nel.org, qiuxu.zhuo@...el.com
Subject: Re: [patch V3 45/60] x86/apic: Sanitize APID ID range validation

On Tue, Aug 08 2023 at 21:34, Qiuxu Zhuo wrote:
>> From: Thomas Gleixner <tglx@...utronix.de>
>> ...
>> Subject: [patch V3 45/60] x86/apic: Sanitize APID ID range validation
>> Now that everything has apic::max_apic_id set and the eventual update for
>> the x2APIC case is in place, switch the apic_id_valid() helper to use
>> apic::max_apic_id and remove the apic::apic_id_valid() callback.
>> 
>
> This patch removes default_apic_id_valid() and all references to it.
> So may also need to remove the useless declaration of
> "extern int default_apic_id_valid(u32 apicid)"
> from arch/x86/include/asm/apic.h?

Yes. Seems I missed that.