[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 8 Aug 2023 10:36:15 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Liao Chang <liaochang1@...wei.com>, andi.shyti@...nel.org,
florian.fainelli@...adcom.com, rjui@...adcom.com,
sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
yangyicong@...ilicon.com, aisheng.dong@....com,
shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
festevam@...il.com, linux-imx@....com, kblaiech@...dia.com,
asmaa@...dia.com, loic.poulain@...aro.org, rfoss@...nel.org,
ardb@...nel.org, gcherian@...vell.com
Cc: linux-i2c@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 4/9] i2c: hisi: Use dev_err_probe in probe function
On 08/08/2023 03:29, Liao Chang wrote:
> Use the dev_err_probe function instead of dev_err in the probe function
> so that the printed messge includes the return value and also handles
> -EPROBE_DEFER nicely.
>
> Reviewed-by: Yicong Yang <yangyicong@...ilicon.com>
> Signed-off-by: Liao Chang <liaochang1@...wei.com>
> ---
> drivers/i2c/busses/i2c-hisi.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-hisi.c b/drivers/i2c/busses/i2c-hisi.c
> index e067671b3ce2..6fc8d6fa43b6 100644
> --- a/drivers/i2c/busses/i2c-hisi.c
> +++ b/drivers/i2c/busses/i2c-hisi.c
> @@ -462,18 +462,14 @@ static int hisi_i2c_probe(struct platform_device *pdev)
> hisi_i2c_disable_int(ctlr, HISI_I2C_INT_ALL);
>
> ret = devm_request_irq(dev, ctlr->irq, hisi_i2c_irq, 0, "hisi-i2c", ctlr);
> - if (ret) {
> - dev_err(dev, "failed to request irq handler, ret = %d\n", ret);
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(dev, ret, "failed to request irq handler\n");
I don't think this is needed:
https://lore.kernel.org/all/20230721094641.77189-1-frank.li@vivo.com/
Best regards,
Krzysztof
Powered by blists - more mailing lists