[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 8 Aug 2023 12:51:23 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Vlad Karpovich <vkarpovi@...nsource.cirrus.com>
CC: Simon Trimmer <simont@...nsource.cirrus.com>,
Richard Fitzgerald <rf@...nsource.cirrus.com>,
<patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] firmware: cs_dsp: Fix new control name check
On Fri, Aug 04, 2023 at 11:52:12AM -0500, Vlad Karpovich wrote:
> Before adding a new FW control, its name is checked against
> existing controls list. But the string length in strncmp used
> to compare controls names is taken from the list, so if beginnings
> of the controls are matching, then the new control is not created.
> For example, if CAL_R control already exists, CAL_R_SELECTED
> is not created.
> The fix is to compare string lengths as well.
>
> Fixes: 6477960755fb ("ASoC: wm_adsp: Move check for control existence")
> Signed-off-by: Vlad Karpovich <vkarpovi@...nsource.cirrus.com>
> ---
Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
Thanks,
Charles
Powered by blists - more mailing lists