linux-kernel - Re: [PATCH v3] sparc: Use shared font data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2023 08:51:16 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux@...blig.org, davem@...emloft.net, sam@...nborg.org,
        benh@...nel.crashing.org, akpm@...ux-foundation.org
Cc:     sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org,
        mpe@...erman.id.au, glaubitz@...sik.fu-berlin.de
Subject: Re: [PATCH v3] sparc: Use shared font data



On 8/6/23 18:09, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> sparc has a 'btext' font used for the console which is almost identical
> to the shared font_sun8x16, so use it rather than duplicating the data.
> 
> They were actually identical until about a decade ago when
>    commit bcfbeecea11c ("drivers: console: font_: Change a glyph from
>                         "broken bar" to "vertical line"")
> 
> which changed the | in the shared font to be a solid
> bar rather than a broken bar.  That's the only difference.
> 
> This was originally spotted by PMD which noticed that PPC does
> the same thing with the same data, and they also share a bunch
> of functions to manipulate the data.
> 
> Tested very lightly with a boot without FS in qemu.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

This survives lots of build testing with no problems, so

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> 
> v3
>   Added 'select FONT_SUPPORT' (to stop modconfig causing the font to be
>    linked into a module rather than the main kernel)
> 
> ---
>  arch/sparc/Kconfig        |   2 +
>  arch/sparc/kernel/btext.c | 365 +-------------------------------------
>  2 files changed, 11 insertions(+), 356 deletions(-)

-- 
~Randy