linux-kernel - Re: [PATCH] x86/linkage: Fix typo of BUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2023 14:03:59 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Jinghao Jia <jinghao@...ux.ibm.com>, linux-kernel@...r.kernel.org
Cc:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com
Subject: Re: [PATCH] x86/linkage: Fix typo of BUILD_VDSO in asm/linkage.h



On 8/8/23 11:23, Jinghao Jia wrote:
> The BUILD_VDSO macro was incorrectly spelled as BULID_VDSO in
> asm/linkage.h. This causes the !defined(BULID_VDSO) directive to always
> evaluate to true.
> 
> Correct the spelling to BUILD_VDSO.
> 
> Fixes: bea75b33895f ("x86/Kconfig: Introduce function padding")
> Signed-off-by: Jinghao Jia <jinghao@...ux.ibm.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  arch/x86/include/asm/linkage.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/linkage.h b/arch/x86/include/asm/linkage.h
> index 0953aa32a324..97a3de7892d3 100644
> --- a/arch/x86/include/asm/linkage.h
> +++ b/arch/x86/include/asm/linkage.h
> @@ -21,7 +21,7 @@
>  #define FUNCTION_PADDING
>  #endif
>  
> -#if (CONFIG_FUNCTION_ALIGNMENT > 8) && !defined(__DISABLE_EXPORTS) && !defined(BULID_VDSO)
> +#if (CONFIG_FUNCTION_ALIGNMENT > 8) && !defined(__DISABLE_EXPORTS) && !defined(BUILD_VDSO)
>  # define __FUNC_ALIGN		__ALIGN; FUNCTION_PADDING
>  #else
>  # define __FUNC_ALIGN		__ALIGN

-- 
~Randy