linux-kernel - Re: [PATCH 1/2] hwmon: Add driver for EMC181x temperature sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 08 Aug 2023 17:54:41 +1000
From:   "Mathew McBride" <matt@...verse.com.au>
To:     "Krzysztof Kozlowski" <krzk@...nel.org>,
        "Mark Tomlinson" <mark.tomlinson@...iedtelesis.co.nz>,
        "Jean Delvare" <jdelvare@...e.com>,
        "Guenter Roeck" <linux@...ck-us.net>
Cc:     linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH 1/2] hwmon: Add driver for EMC181x temperature sensors

Hi Krzysztof,

On Tue, Aug 8, 2023, at 5:38 PM, Krzysztof Kozlowski wrote:
> On 08/08/2023 03:31, Mark Tomlinson wrote:
> > This patch adds a HWMON driver for the EMC1812, EMC1813, EMC1814,
> > EMC1815 and EMC1833 temperature sensor chips from microchip. Does not
> > currently support the alert outputs.
> > 
> > Signed-off-by: Mark Tomlinson <mark.tomlinson@...iedtelesis.co.nz>
> > Co-developed-by: Mathew McBride <matt@...verse.com.au>
> > Signed-off-by: Mathew McBride <matt@...verse.com.au>
> 
> The order of these tags is clearly not correct. It says Mathew is
> sending, but you are not Mathew?

Just to clarify, Mark has developed this version based off something I wrote a while ago:

https://gitlab.com/traversetech/ls1088firmware/traverse-sensors/-/blob/master/emc181x/emc181x.c?ref_type=heads

Hence my copyright is listed in the header.

I advised him to list the authors in that order following the example in the kernel's "submitting patches" guide [2] which provides an example of such a situation:

https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

If I interpreted the guidelines incorrectly, happy to be corrected.

Best Regards,
Matt