linux-kernel - Re: [PATCH] Revert "Input: synaptics - enable InterTouch for the ThinkPad P1 G3"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 08 Aug 2023 17:49:23 -0400
From:   Lyude Paul <lyude@...hat.com>
To:     Sebastian Wick <sebastian.wick@...hat.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Aman Dhoot <amandhoot12@...il.com>,
        Mark Pearson <markpearson@...ovo.com>,
        Raul Rangel <rrangel@...omium.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Andrew Duggan <aduggan@...aptics.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "Input: synaptics - enable InterTouch for the
 ThinkPad P1 G3"

Hm, This looks fine to me (if not as a final fix, certainly as a workaround)

Reviewed-by: Lyude Paul <lyude@...hat.com>

However, this is definitely something we probably should try to fix at some
point - as I imagine this must be happening because something regarding how
clicks are reported must have changed again. Andrew, do you have any idea?

On Tue, 2023-08-08 at 17:28 +0200, Sebastian Wick wrote:
> This reverts commit 7984b43542070f5888546d95b48003c4a8af7c0f to make the
> touchpad usable again.
> 
> Tapping does not generate any events for user space and moving the
> cursor is janky. Disabling InterTouch fixes those issues.
> 
> Signed-off-by: Sebastian Wick <sebastian.wick@...hat.com>
> ---
>  drivers/input/mouse/synaptics.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index ada299ec5bba..0e01df88cf69 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -182,7 +182,6 @@ static const char * const smbus_pnp_ids[] = {
>  	"LEN0099", /* X1 Extreme Gen 1 / P1 Gen 1 */
>  	"LEN009b", /* T580 */
>  	"LEN0402", /* X1 Extreme Gen 2 / P1 Gen 2 */
> -	"LEN040f", /* P1 Gen 3 */
>  	"LEN200f", /* T450s */
>  	"LEN2044", /* L470  */
>  	"LEN2054", /* E480 */

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat