linux-kernel - Re: [PATCH 1/2] platform/x86/amd: Introduce AMD Address Translation Library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2023 10:28:51 -0400
From:   Yazen Ghannam <yazen.ghannam@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     yazen.ghannam@....com,
        "Limonciello, Mario" <mario.limonciello@....com>,
        linux-edac@...r.kernel.org, hdegoede@...hat.com,
        markgross@...nel.org, platform-driver-x86@...r.kernel.org,
        "Luck, Tony" <tony.luck@...el.com>, linux-kernel@...r.kernel.org,
        avadhut.naik@....com
Subject: Re: [PATCH 1/2] platform/x86/amd: Introduce AMD Address Translation
 Library

On 8/8/2023 10:20 AM, Borislav Petkov wrote:
> On Tue, Aug 08, 2023 at 10:07:19AM -0400, Yazen Ghannam wrote:
>> But just because there's existing vendor-specific code in arch/x86 doesn't
>> necessarily mean we should keep adding to it. So is this okay?
> 
> I'd say since it is not so close to the arch/ part, drivers/ras/ is more
> fitting IMO. Just like mce_amd is in drivers/edac/.
>

Okay, then I'll move this set to drivers/ras, if there are no objections 
from others.

> Which reminds me: why aren't you adding it to
> 
> drivers/edac/mce_amd.c
> 
> ?
> 
> That is an MCE decoder *already*.
> 

Because this isn't intended to be only for MCA errors. The translation 
code is related to the AMD Data Fabric. And it'll be a common back-end 
for memory errors coming from MCA and CXL.

Thanks,
Yazen