[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 08 Aug 2023 16:55:00 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Ulf Hansson" <ulf.hansson@...aro.org>
Cc: "Yinbo Zhu" <zhuyinbo@...ngson.cn>,
"Rob Herring" <robh+dt@...nel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
"Conor Dooley" <conor+dt@...nel.org>, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
soc@...nel.org, "Jianmin Lv" <lvjianmin@...ngson.cn>,
wanghongliang@...ngson.cn, "Liu Peibao" <liupeibao@...ngson.cn>,
loongson-kernel@...ts.loongnix.cn, loongarch@...ts.linux.dev,
"Liu Yun" <liuyun@...ngson.cn>
Subject: Re: [PATCH v6 2/2] soc: loongson2_pm: add power management support
On Tue, Aug 8, 2023, at 16:42, Ulf Hansson wrote:
> On Thu, 3 Aug 2023 at 09:03, Arnd Bergmann <arnd@...db.de> wrote:
>>
>> On Thu, Aug 3, 2023, at 08:37, Yinbo Zhu wrote:
>> > The Loongson-2's power management controller was ACPI, supports ACPI
>> > S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To
>> > Disk), ACPI S5 (Soft Shutdown) and supports multiple wake-up methods
>> > (USB, GMAC, PWRBTN, etc.). This driver was to add power management
>> > controller support that base on dts for Loongson-2 series SoCs.
>> >
>> > Co-developed-by: Liu Yun <liuyun@...ngson.cn>
>> > Signed-off-by: Liu Yun <liuyun@...ngson.cn>
>> > Co-developed-by: Liu Peibao <liupeibao@...ngson.cn>
>> > Signed-off-by: Liu Peibao <liupeibao@...ngson.cn>
>> > Cc: soc@...nel.org
>> > Cc: Ulf Hansson <ulf.hansson@...aro.org>
>> > Signed-off-by: Yinbo Zhu <zhuyinbo@...ngson.cn>
>>
>> I'm still waiting for Ulf to take a look here to see whether
>> this should be in drivers/genpd instead, but he might still
>> be on vacation.
>
> I don't think this belongs in drivers/genpd/ as it's not a genpd
> provider. Besides that, no further comments from me at this point.
Ok, thanks!
Let's try to finish discussing the suspend-address question
and merge it through the soc tree once that is resolved then.
Arnd
Powered by blists - more mailing lists