linux-kernel - Re: [PATCH V9 03/23] mmc: core: Announce successful insertion of an SD UHS-II card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2023 12:24:40 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Victor Shih <victorshihgli@...il.com>
Cc:     adrian.hunter@...el.com, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, benchuanggli@...il.com,
        HL.Liu@...esyslogic.com.tw, Greg.tu@...esyslogic.com.tw,
        takahiro.akashi@...aro.org, dlunev@...omium.org,
        Victor Shih <victor.shih@...esyslogic.com.tw>
Subject: Re: [PATCH V9 03/23] mmc: core: Announce successful insertion of an
 SD UHS-II card

On Fri, 21 Jul 2023 at 12:14, Victor Shih <victorshihgli@...il.com> wrote:
>
> From: Victor Shih <victor.shih@...esyslogic.com.tw>

Authorship?

>
> Update in previous version:

Please, drop the above.

> To inform the users about SD UHS-II cards, let's extend the print at card
> insertion with a "UHS-II" substring. Within this change, it seems
> reasonable to convert from using "ultra high speed" into "UHS-I speed", for
> the UHS-I type, as it should makes it more clear.
>
> Note that, the new print for UHS-II cards doesn't include the actual
> selected speed mode. Instead, this is going to be added from subsequent
> change.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
> Signed-off-by: Victor Shih <victor.shih@...esyslogic.com.tw>
> ---
>
> Updates in V7:
>  - Drop MMC_TIMING_SD_UHS2 in favor of MMC_TIMING_UHS2_SPEED_A in
>    mmc_card_uhs2 function.
>
> Updates in V4:
>  - Make mmc_card_uhs2() take struct mmc_host* as in-param.
>
> ---
>
>  drivers/mmc/core/bus.c  | 4 +++-
>  drivers/mmc/core/host.h | 7 +++++++
>  2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
> index cf32cf135781..d9a3b3d38d8b 100644
> --- a/drivers/mmc/core/bus.c
> +++ b/drivers/mmc/core/bus.c
> @@ -341,7 +341,9 @@ int mmc_add_card(struct mmc_card *card)
>         if (mmc_card_hs(card))
>                 speed_mode = "high speed ";
>         else if (mmc_card_uhs(card))
> -               speed_mode = "ultra high speed ";
> +               speed_mode = "UHS-I speed ";
> +       else if (mmc_card_uhs2(card->host))
> +               speed_mode = "UHS-II speed ";
>         else if (mmc_card_ddr52(card))
>                 speed_mode = "high speed DDR ";
>         else if (mmc_card_hs200(card))
> diff --git a/drivers/mmc/core/host.h b/drivers/mmc/core/host.h
> index 48c4952512a5..9f6e5e31dfea 100644
> --- a/drivers/mmc/core/host.h
> +++ b/drivers/mmc/core/host.h
> @@ -89,5 +89,12 @@ static inline bool mmc_card_sd_express(struct mmc_host *host)
>                 host->ios.timing == MMC_TIMING_SD_EXP_1_2V;
>  }
>
> +static inline bool mmc_card_uhs2(struct mmc_host *host)
> +{
> +       return host->ios.timing == MMC_TIMING_UHS2_SPEED_A ||
> +              host->ios.timing == MMC_TIMING_UHS2_SPEED_A_HD ||
> +              host->ios.timing == MMC_TIMING_UHS2_SPEED_B ||
> +              host->ios.timing == MMC_TIMING_UHS2_SPEED_B_HD;
> +}
>  #endif
>

Kind regards
Uffe