[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 8 Aug 2023 17:59:38 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Dylan Hung <dylan_hung@...eedtech.com>, jk@...econstruct.com.au,
alexandre.belloni@...tlin.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
joel@....id.au, andrew@...id.au, p.zabel@...gutronix.de,
linux-i3c@...ts.infradead.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Cc: BMC-SW@...eedtech.com, kobedylan@...il.com
Subject: Re: [PATCH 2/3] dt-bindings: i3c: ast2600: Add resets and reset-names
On 08/08/2023 17:42, Dylan Hung wrote:
> Add two reset lines to the AST2600 I3C controller:
> - core_rst: the reset line of the controller itself
> - global_rst: the reset line of the I3C global register block. Since all
> six I3C controllers in AST2600 share this global register block, the
> driver needs to handle this carefully. Generally, this reset line should
> only need to be de-asserted.
The commit msg does not explain why this is now required.
>
> Signed-off-by: Dylan Hung <dylan_hung@...eedtech.com>
> ---
> .../devicetree/bindings/i3c/aspeed,ast2600-i3c.yaml | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i3c/aspeed,ast2600-i3c.yaml b/Documentation/devicetree/bindings/i3c/aspeed,ast2600-i3c.yaml
> index fcc3dbff9c9a..3166d6f3a39c 100644
> --- a/Documentation/devicetree/bindings/i3c/aspeed,ast2600-i3c.yaml
> +++ b/Documentation/devicetree/bindings/i3c/aspeed,ast2600-i3c.yaml
> @@ -23,7 +23,12 @@ properties:
> maxItems: 1
>
> resets:
> - maxItems: 1
> + maxItems: 2
> +
> + reset-names:
> + items:
> + - const: core_rst
> + - const: global_rst
>
Drop "_rst" suffixes from both.
> interrupts:
> maxItems: 1
> @@ -48,6 +53,8 @@ required:
> - compatible
> - reg
> - clocks
> + - resets
> + - reset-names
Best regards,
Krzysztof
Powered by blists - more mailing lists