linux-kernel - Re: [PATCH v9 2/7] nvmem: core: Return NULL when no nvmem layout is found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 08 Aug 2023 08:38:10 +0200
From:   Michael Walle <michael@...le.cc>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Robert Marko <robert.marko@...tura.hr>,
        Luka Perkov <luka.perkov@...tura.hr>,
        linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>,
        Chen-Yu Tsai <wenst@...omium.org>,
        Daniel Golle <daniel@...rotopia.org>,
        Rafał Miłecki <rafal@...ecki.pl>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        kernel test robot <lkp@...el.com>,
        Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH v9 2/7] nvmem: core: Return NULL when no nvmem layout is
 found

Am 2023-08-08 08:29, schrieb Miquel Raynal:
> Currently, of_nvmem_layout_get_container() returns NULL on error, or an
> error pointer if either CONFIG_NVMEM or CONFIG_OF is turned off. We
> should likely avoid this kind of mix for two reasons: to clarify the
> intend and anyway fix the !CONFIG_OF which will likely always if we use
> this helper somewhere else. Let's just return NULL when no layout is
> found, we don't need an error value here.
> 
> Link: 
> https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and-null/
> Fixes: 266570f496b9 ("nvmem: core: introduce NVMEM layouts")
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/r/202308030002.DnSFOrMB-lkp@intel.com/
> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>

Reviewed-by: Michael Walle <michael@...le.cc>