[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 8 Aug 2023 11:06:41 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Meng Li <li.meng@....com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
Huang Rui <ray.huang@....com>, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org, x86@...nel.org,
linux-acpi@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>,
linux-kselftest@...r.kernel.org,
Nathan Fontenot <nathan.fontenot@....com>,
Deepak Sharma <deepak.sharma@....com>,
Alex Deucher <alexander.deucher@....com>,
Mario Limonciello <mario.limonciello@....com>,
Shimmer Huang <shimmer.huang@....com>,
Perry Yuan <Perry.Yuan@....com>,
Xiaojian Du <Xiaojian.Du@....com>,
Viresh Kumar <viresh.kumar@...aro.org>,
Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH V1 2/6] cpufreq: amd-pstate: Enable AMD Pstate Preferred
Core Supporting.
On Tue, Aug 08, 2023 at 04:09:57PM +0800, Meng Li wrote:
> +static int amd_pstate_get_highest_perf(int cpu, u64 *highest_perf)
> +{
> + int ret;
> +
> + if (boot_cpu_has(X86_FEATURE_CPPC)) {
> + u64 cap1;
> +
> + ret = rdmsrl_safe_on_cpu(cpu, MSR_AMD_CPPC_CAP1, &cap1);
> + if (ret)
> + return ret;
> + WRITE_ONCE(*highest_perf, AMD_CPPC_HIGHEST_PERF(cap1));
> + } else {
> + ret = cppc_get_highest_perf(cpu, highest_perf);
> + }
> +
> + return (ret);
> +}
> +
> +static void amd_pstate_init_prefcore(void)
> +{
> + int cpu, ret;
> + u64 highest_perf;
> +
> + if (no_prefcore)
> + return;
> +
> + for_each_possible_cpu(cpu) {
> + ret = amd_pstate_get_highest_perf(cpu, &highest_perf);
> + if (ret)
> + break;
So what is the intended behaviour when online != possible ?
> + sched_set_itmt_core_prio(highest_perf, cpu);
> + }
> +
> + /*
> + * This code can be run during CPU online under the
> + * CPU hotplug locks, so sched_set_amd_prefcore_support()
> + * cannot be called from here. Queue up a work item
> + * to invoke it.
> + */
> + schedule_work(&sched_prefcore_work);
> +}
Powered by blists - more mailing lists