linux-kernel - Re: [RFC PATCH v2 0/6] bpf: fprobe: rethook: Use ftrace_regs instead of pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2023 23:53:46 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     Florent Revest <revest@...omium.org>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-trace-kernel@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        bpf <bpf@...r.kernel.org>, Sven Schnelle <svens@...ux.ibm.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alan Maguire <alan.maguire@...cle.com>,
        Mark Rutland <mark.rutland@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC PATCH v2 0/6] bpf: fprobe: rethook: Use ftrace_regs
 instead of pt_regs

On Tue, 8 Aug 2023 16:29:27 +0200
Florent Revest <revest@...omium.org> wrote:

> On Mon, Aug 7, 2023 at 8:48 AM Masami Hiramatsu (Google)
> <mhiramat@...nel.org> wrote:
> >
> > Florent, feel free to add your rethook for arm64, but please do not remove
> > kretprobe trampoline yet. It is another discussion point. We may be possible
> > to use ftrace_regs for kretprobe by ftrace_partial_regs() but kretprobe
> > allows nest probe. (maybe we can skip that case?)
> 
> Ack :)
> 
> >  arch/Kconfig                    |    1 +
> >  arch/arm64/include/asm/ftrace.h |   11 ++++++
> >  arch/loongarch/Kconfig          |    1 +
> >  arch/s390/Kconfig               |    1 +
> >  arch/x86/Kconfig                |    1 +
> >  arch/x86/kernel/rethook.c       |    9 +++--
> >  include/linux/fprobe.h          |    4 +-
> >  include/linux/ftrace.h          |   56 ++++++++++++++++++-----------
> >  include/linux/rethook.h         |   11 +++---
> >  kernel/kprobes.c                |    9 ++++-
> >  kernel/trace/Kconfig            |    9 ++++-
> >  kernel/trace/bpf_trace.c        |   14 +++++--
> >  kernel/trace/fprobe.c           |    8 ++--
> >  kernel/trace/rethook.c          |   16 ++++----
> >  kernel/trace/trace_fprobe.c     |   76 ++++++++++++++++++++++++---------------
> >  kernel/trace/trace_probe_tmpl.h |    2 +
> >  lib/test_fprobe.c               |   10 +++--
> >  samples/fprobe/fprobe_example.c |    4 +-
> 
> I believe that Documentation/trace/fprobe.rst should also be modified
> following the API change

Indeed. Let me update it.

Thanks!


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>