lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 8 Aug 2023 13:29:07 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Liao Chang <liaochang1@...wei.com>, florian.fainelli@...adcom.com,
        rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, yangyicong@...ilicon.com,
        aisheng.dong@....com, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        kblaiech@...dia.com, asmaa@...dia.com, loic.poulain@...aro.org,
        rfoss@...nel.org, ardb@...nel.org, gcherian@...vell.com,
        linux-i2c@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 2/9] i2c: mlxbf: Use dev_err_probe in probe function

Hi Krzysztof,

On Tue, Aug 08, 2023 at 10:36:40AM +0200, Krzysztof Kozlowski wrote:
> On 08/08/2023 03:29, Liao Chang wrote:
> > Use the dev_err_probe function instead of dev_err in the probe function
> > so that the printed messge includes the return value and also handles
> > -EPROBE_DEFER nicely.
> > 
> > Reviewed-by: Andi Shyti <andi.shyti@...nel.org>
> > Signed-off-by: Liao Chang <liaochang1@...wei.com>
> 
> ...
> 
> > @@ -2413,10 +2399,8 @@ static int mlxbf_i2c_probe(struct platform_device *pdev)
> >  	ret = devm_request_irq(dev, irq, mlxbf_i2c_irq,
> >  			       IRQF_SHARED | IRQF_PROBE_SHARED,
> >  			       dev_name(dev), priv);
> > -	if (ret < 0) {
> > -		dev_err(dev, "Cannot get irq %d\n", irq);
> > -		return ret;
> > -	}
> > +	if (ret < 0)
> > +		return dev_err_probe(dev, ret, "Cannot get irq %d\n", irq);
> 
> I don't think this is needed:
> https://lore.kernel.org/all/20230721094641.77189-1-frank.li@vivo.com/

Hmm, that's a bit borderline, I'd say. The change to
devm_request_irq/devm_request_threaded_irq_probe seems like
something for another series. But for now, I think I'll accept
this as it is since it fits within the scope of this current
series.

Andi

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ