linux-kernel - Re: [PATCH 1/2] pinctrl: iproc-gpio: Silence probe deferral messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2023 16:09:24 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Florian Fainelli <florian.fainelli@...adcom.com>
Cc:     linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        "open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "moderated list:BROADCOM IPROC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/2] pinctrl: iproc-gpio: Silence probe deferral messages

On Mon, Aug 07, 2023 at 02:30:21PM -0700, Florian Fainelli wrote:
> We can have gpiochip_add_data() return -EPROBE_DEFER which will make us
> produce the "unable to add GPIO chip" message which is confusing. Use
> dev_err_probe() to silence probe deferral messages.

...

>  	ret = gpiochip_add_data(gc, chip);
>  	if (ret < 0) {
> -		dev_err(dev, "unable to add GPIO chip\n");
> +		dev_err_probe(dev, ret, "unable to add GPIO chip\n");
>  		return ret;

	return dev_err_probe(...);

>  	}

-- 
With Best Regards,
Andy Shevchenko