linux-kernel - Re: [PATCH] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2023 12:26:17 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Devarsh Thakkar <devarsht@...com>, mchehab@...nel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     praneeth@...com, nm@...com, vigneshr@...com, a-bhatia1@...com,
        j-luthra@...com, b-brnich@...com, detheridge@...com,
        p-mantena@...com, vijayp@...com
Subject: Re: [PATCH] dt-bindings: media: Add bindings for Imagination E5010
 JPEG Encoder driver

On 08/08/2023 12:20, Devarsh Thakkar wrote:
>>>> +properties:
>>>> +  compatible:
>>>> +    const: img,e5010-jpeg-enc
>>>
>>> Your description suggests that this is part of TI SoC. Pretty often
>>> licensed blocks cannot be used on their own and need some
>>> customizations. Are you sure your block does not need any customization
>>> thus no dedicated compatible is needed?
>>>
>>
>> There is a wrapper for interfacing this core with TI SoC, I will recheck this
>> interfacing but I believe nothing changes from programming perspective as
>> there is 1-to-1 maintained between the clocks and signals w.r.t actual E5010
>> core.
>>
> 
> Just to add to above, on a second thought we think it would be  better to
> still have a separate compatible for TI as you suggested (since we have a
> wrapper) so that it allows any customization needed for future. So compatible
> enum would look like :
> 
>     oneOf:
>       - items:
>         - const: ti,e5010-jpeg-enc
>         - const: img,e5010-jpeg-enc
>       - const: img,e5010-jpeg-enc
> 
> Thanks for the suggestion.

Yeah, it's fine, assuming block can be used as img,e5010-jpeg-enc on its
own.

Best regards,
Krzysztof