[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 8 Aug 2023 16:22:03 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Wenhua Lin <Wenhua.Lin@...soc.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
Orson Zhai <orsonzhai@...il.com>,
Baolin Wang <baolin.wang@...ux.alibaba.com>,
Chunyan Zhang <zhang.lyra@...il.com>,
linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
wenhua lin <wenhua.lin1994@...il.com>,
Xiongpeng Wu <xiongpeng.wu@...soc.com>
Subject: Re: [PATCH 1/3] gpio: sprd: Modify the calculation method of eic
number
On Tue, Aug 08, 2023 at 11:31:06AM +0800, Wenhua Lin wrote:
> Automatic calculation through matching nodes,
> subsequent projects can avoid modifying driver files.
You sent three patches which has to be meant a series in three independent
(unlinked) messages. Do not forget to use --thread so it become a such.
...
> struct sprd_eic *sprd_eic;
> struct resource *res;
> int ret, i;
> + u16 num_banks = 0;
Preserve reversed xmas tree ordering.
...
> @@ -630,10 +631,12 @@ static int sprd_eic_probe(struct platform_device *pdev)
> sprd_eic->chip.set = sprd_eic_set;
> fallthrough;
> case SPRD_EIC_ASYNC:
> + fallthrough;
> case SPRD_EIC_SYNC:
> sprd_eic->chip.get = sprd_eic_get;
> break;
> case SPRD_EIC_LATCH:
> + fallthrough;
> default:
> break;
Pointless changes. And actually create the code less maintainable.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists