linux-kernel - Re: [PATCH 1/2] riscv: dts: starfive - Add crypto and DMA node for JH7110

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2023 08:16:03 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Jia Jie Ho <jiajie.ho@...rfivetech.com>
Cc:     Emil Renner Berthing <kernel@...il.dk>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>, devicetree@...r.kernel.org,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] riscv: dts: starfive - Add crypto and DMA node for
 JH7110

On Tue, Aug 08, 2023 at 02:11:49PM +0800, Jia Jie Ho wrote:
> Add hardware crypto module and dedicated dma controller node to StarFive
> JH7110 SoC.
> 
> Co-developed-by: Huan Feng <huan.feng@...rfivetech.com>
> Signed-off-by: Huan Feng <huan.feng@...rfivetech.com>
> Signed-off-by: Jia Jie Ho <jiajie.ho@...rfivetech.com>
> Acked-by: Palmer Dabbelt <palmer@...osinc.com>
> ---
>  arch/riscv/boot/dts/starfive/jh7110.dtsi | 28 ++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> index a608433200e8..47cd12ccc988 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> @@ -821,6 +821,34 @@ watchdog@...70000 {
>  				 <&syscrg JH7110_SYSRST_WDT_CORE>;
>  		};
>  
> +		crypto: crypto@...00000 {
> +			compatible = "starfive,jh7110-crypto";
> +			reg = <0x0 0x16000000 0x0 0x4000>;
> +			clocks = <&stgcrg JH7110_STGCLK_SEC_AHB>,
> +				 <&stgcrg JH7110_STGCLK_SEC_MISC_AHB>;
> +			clock-names = "hclk", "ahb";
> +			interrupts = <28>;
> +			resets = <&stgcrg JH7110_STGRST_SEC_AHB>;
> +			dmas = <&sdma 1 2>, <&sdma 0 2>;
> +			dma-names = "tx", "rx";
> +		};
> +
> +		sdma: dma@...08000 {
> +			compatible = "arm,pl080", "arm,primecell";
> +			arm,primecell-periphid = <0x00041080>;
> +			reg = <0x0 0x16008000 0x0 0x4000>;
> +			interrupts = <29>;
> +			clocks = <&stgcrg JH7110_STGCLK_SEC_AHB>,
> +				 <&stgcrg JH7110_STGCLK_SEC_MISC_AHB>;
> +			clock-names = "hclk", "apb_pclk";
> +			resets = <&stgcrg JH7110_STGRST_SEC_AHB>;
> +			lli-bus-interface-ahb1;
> +			mem-bus-interface-ahb1;
> +			memcpy-burst-size = <256>;
> +			memcpy-bus-width = <32>;
> +			#dma-cells = <2>;
> +		};
> +

Against linux-next, I get these warnings:
arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@...08000: $nodename:0: 'dma@...08000' does not match '^dma-controller(@.*)?$'
        from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@...08000: clocks: [[26, 15], [26, 16]] is too long
        from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@...08000: clock-names: ['hclk', 'apb_pclk'] is too long
        from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@...08000: Unevaluated properties are not allowed ('#dma-cells' was unexpected)
        from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@...08000: $nodename:0: 'dma@...08000' does not match '^dma-controller(@.*)?$'
        from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@...08000: clocks: [[26, 15], [26, 16]] is too long
        from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@...08000: clock-names: ['hclk', 'apb_pclk'] is too long
        from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@...08000: Unevaluated properties are not allowed ('#dma-cells' was unexpected)
        from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#

Please fix these & submit a tested v2.

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)