[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5095df45-c7bf-9040-1720-09a562b8714a@huaweicloud.com>
Date: Wed, 9 Aug 2023 11:05:49 +0800
From: "GONG, Ruiqi" <gongruiqi@...weicloud.com>
To: Florian Westphal <fw@...len.de>
Cc: Pablo Neira Ayuso <pablo@...filter.org>,
Jozsef Kadlecsik <kadlec@...filter.org>,
Roopa Prabhu <roopa@...dia.com>,
Nikolay Aleksandrov <razor@...ckwall.org>,
Kees Cook <keescook@...omium.org>,
netfilter-devel@...r.kernel.org, coreteam@...filter.org,
netdev@...r.kernel.org, linux-hardening@...r.kernel.org,
linux-kernel@...r.kernel.org,
Wang Weiyang <wangweiyang2@...wei.com>,
Xiu Jianfeng <xiujianfeng@...wei.com>
Subject: Re: [PATCH] netfilter: ebtables: fix fortify warnings
On 2023/08/08 23:54, Florian Westphal wrote:
>
> [...]
>>
>> diff --git a/include/uapi/linux/netfilter_bridge/ebtables.h b/include/uapi/linux/netfilter_bridge/ebtables.h
>> index a494cf43a755..e634da196d08 100644
>> --- a/include/uapi/linux/netfilter_bridge/ebtables.h
>> +++ b/include/uapi/linux/netfilter_bridge/ebtables.h
>> @@ -182,12 +182,14 @@ struct ebt_entry {
>> unsigned char sourcemsk[ETH_ALEN];
>> unsigned char destmac[ETH_ALEN];
>> unsigned char destmsk[ETH_ALEN];
>> - /* sizeof ebt_entry + matches */
>> - unsigned int watchers_offset;
>> - /* sizeof ebt_entry + matches + watchers */
>> - unsigned int target_offset;
>> - /* sizeof ebt_entry + matches + watchers + target */
>> - unsigned int next_offset;
>> + struct_group(offsets,
>> + /* sizeof ebt_entry + matches */
>
> This is an UAPI header, I think you need to use __struct_group here.
Thanks for the reminder! I've fixed it in v2:
https://lore.kernel.org/all/20230808133038.771316-1-gongruiqi@huaweicloud.com/
Please review it :)
Powered by blists - more mailing lists