[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CANiq72ka691RCpO02jBT9yOX9_jQTe5n-GVG35x7F25B+HdX8Q@mail.gmail.com>
Date: Wed, 9 Aug 2023 21:28:55 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Qingsong Chen <changxian.cqs@...group.com>
Cc: linux-kernel@...r.kernel.org,
田洪亮 <tate.thl@...group.com>,
Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>,
Wedson Almeida Filho <wedsonaf@...il.com>,
Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>,
Sergio González Collado <sergio.collado@...il.com>,
rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v3] rust: macros: vtable: fix `HAS_*` redefinition (`gen_const_name`)
On Tue, Aug 8, 2023 at 4:54 AM Qingsong Chen <changxian.cqs@...group.com> wrote:
>
> If we define the same function name twice in a trait (using `#[cfg]`),
> the `vtable` macro will redefine its `gen_const_name`, e.g. this will
> define `HAS_BAR` twice:
>
> #[vtable]
> pub trait Foo {
> #[cfg(CONFIG_X)]
> fn bar();
>
> #[cfg(not(CONFIG_X))]
> fn bar(x: usize);
> }
>
> Fixes: b44becc5ee80 ("rust: macros: add `#[vtable]` proc macro")
> Signed-off-by: Qingsong Chen <changxian.cqs@...group.com>
Applied to `rust-fixes`, thanks everyone!
Cheers,
Miguel
Powered by blists - more mailing lists