linux-kernel - RE: [PATCH] net/ethernet/realtek: Add Realtek automotive PCIe driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5462aca9d85452fa40dc7ee88bc8d26@realtek.com>
Date:   Wed, 9 Aug 2023 06:42:27 +0000
From:   Justin Lai <justinlai0215@...ltek.com>
To:     Jiri Pirko <jiri@...nulli.us>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net/ethernet/realtek: Add Realtek automotive PCIe driver

> Thu, Aug 03, 2023 at 03:20:46PM CEST, justinlai0215@...ltek.com wrote:
> >Hi, Jiri Pirko
> >
> >Our device is multi-function, one of which is netdev and the other is
> character device. For character devices, we have some custom functions that
> must use copy_from_user or copy_to_user to pass data.
> 
> 1. Don't top post
> 2. That's nice you have it, but it is totally unacceptable. That's my
>    point. This is not about wrapping your out-of-tree driver and sending
>    it as is. You have to make sure you comply with the upstream code.
>    Which you don't, not even remotelly.

Thank you for your reply, I will refer to your suggestions to modify my code.