linux-kernel - Re: [PATCH next v2 1/2] mmc: sunplus: Fix error handling in spmmc_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4eb3558-c270-4aea-94a8-b24b8d3a1987@kadam.mountain>
Date:   Wed, 9 Aug 2023 10:40:30 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc:     tonyhuang.sunplus@...il.com, lhjeff911@...il.com,
        ulf.hansson@...aro.org, arnd@...db.de, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, error27@...il.com,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next v2 1/2] mmc: sunplus: Fix error handling in
 spmmc_drv_probe()

On Wed, Aug 09, 2023 at 12:18:11AM -0700, Harshit Mogalapalli wrote:
> When mmc allocation succeeds, the error paths are not freeing mmc.
> 
> Fix the above issue by changing mmc_alloc_host() to devm_mmc_alloc_host()
> to simplify the error handling. Remove label 'probe_free_host' as devm_*
> api takes care of freeing, also remove mmc_free_host() from remove
> function as devm_* takes care of freeing.
> 
> Fixes: 4e268fed8b18 ("mmc: Add mmc driver for Sunplus SP7021")
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/all/a3829ed3-d827-4b9d-827e-9cc24a3ec3bc@moroto.mountain/
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> ---
> This is based on static analysis with smatch, only compile tested.
> 
> v1->v2: Simplify code by using devm_mmc_alloc_host() instead of
> mmc_alloc_host() (Ulf Hansson's suggestion)

Nice.

Both patches look good to me.
Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter