linux-kernel - Re: [PATCH V6 7/8] firmware: imx: scu-irq: enlarge the IMX_SC_IRQ_NUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZBECPn+JC1PF6hvvroZZBzuVXTU2Zy+Kc_giKsFUFQxVA@mail.gmail.com>
Date:   Wed, 9 Aug 2023 10:42:36 +0300
From:   Daniel Baluta <daniel.baluta@...il.com>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc:     shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, aisheng.dong@....com,
        alexander.stein@...tq-group.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Peng Fan <peng.fan@....com>
Subject: Re: [PATCH V6 7/8] firmware: imx: scu-irq: enlarge the IMX_SC_IRQ_NUM_GROUP

On Mon, Aug 7, 2023 at 4:11 PM Peng Fan (OSS) <peng.fan@....nxp.com> wrote:
>
> From: Peng Fan <peng.fan@....com>
>
> Per SCFW update, update the IMX_SC_IRQ_NUM_GROUP to 9.
>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  drivers/firmware/imx/imx-scu-irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c
> index 6549f3792a0f..8d902db1daf2 100644
> --- a/drivers/firmware/imx/imx-scu-irq.c
> +++ b/drivers/firmware/imx/imx-scu-irq.c
> @@ -14,7 +14,7 @@
>
>  #define IMX_SC_IRQ_FUNC_ENABLE 1
>  #define IMX_SC_IRQ_FUNC_STATUS 2
> -#define IMX_SC_IRQ_NUM_GROUP   4
> +#define IMX_SC_IRQ_NUM_GROUP   9

This is tricky. Shouldn't we have some sort of versioning so that the user knows
that kernel and scfw are not compatible anymore?