linux-kernel - Re: [PATCH] bus: ti-sysc: Fix a build warning with W=1 for sysconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230809101101.7pbe7fhrlfcblcqk@dhruva>
Date:   Wed, 9 Aug 2023 15:41:01 +0530
From:   Dhruva Gole <d-gole@...com>
To:     Tony Lindgren <tony@...mide.com>
CC:     <linux-omap@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Keerthy <j-keerthy@...com>, Kevin Hilman <khilman@...libre.com>,
        Nishanth Menon <nm@...com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] bus: ti-sysc: Fix a build warning with W=1 for sysconfig

On Aug 09, 2023 at 12:56:33 +0300, Tony Lindgren wrote:
> Dhruva reported a build warning with W=1 for "Function parameter or member
> 'sysconfig' not described in 'sysc'". Let's document sysconfig to fix this.
> 
> Reported-by: Dhruva Gole <d-gole@...com>
> Signed-off-by: Tony Lindgren <tony@...mide.com>
> ---

Probably best to include a Fixes: commit no?

>  drivers/bus/ti-sysc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -109,6 +109,7 @@ static const char * const clock_names[SYSC_MAX_CLOCKS] = {
>   * @cookie: data used by legacy platform callbacks
>   * @name: name if available
>   * @revision: interconnect target module revision
> + * @sysconfig: saved sysconfig register value
>   * @reserved: target module is reserved and already in use
>   * @enabled: sysc runtime enabled status
>   * @needs_resume: runtime resume needed on resume from suspend
> -- 
> 2.41.0

-- 
Best regards,
Dhruva Gole <d-gole@...com>