linux-kernel - Re: [PATCH 4/7] arm64: dts: qcom: apq8016-sbc: Rename ov5640 enable-gpios to powerdown-gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad6c15b5-4fad-4db6-8210-839cb1ca2f4b@linaro.org>
Date:   Wed, 9 Aug 2023 14:08:10 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>, agross@...nel.org,
        andersson@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        loic.poulain@...aro.org, rfoss@...nel.org
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/7] arm64: dts: qcom: apq8016-sbc: Rename ov5640
 enable-gpios to powerdown-gpios

On 9.08.2023 14:04, Bryan O'Donoghue wrote:
> There are two control lines controlled by GPIO going into ov5640
> 
> - Reset
> - Powerdown
> 
> The driver and yaml expect "reset-gpios" and "powerdown-gpios" there has
> never been an "enable-gpios".
> 
> Fixes: 39e0ce6cd1bf ("arm64: dts: qcom: apq8016-sbc: Add CCI/Sensor nodes")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
Assuming that the polarity is still correct (maybe the og commiter had
different assumptions about what this pin did):

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad