lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 9 Aug 2023 14:21:51 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mingzai Sun <szp2017@...il.com>
Cc:     forest@...ttletooquiet.net, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6655: Change camel case variables to snake
 case

On Sat, Aug 05, 2023 at 11:57:39AM +0800, Mingzai Sun wrote:
> Change camel case to snake case.
> Issue found by checkpatch.
> 
> Signed-off-by: Mingzai Sun <szp2017@...il.com>
> ---
>  drivers/staging/vt6655/srom.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
> index ee5ca4db74dc..812964ab68c5 100644
> --- a/drivers/staging/vt6655/srom.c
> +++ b/drivers/staging/vt6655/srom.c
> @@ -49,7 +49,7 @@
>   * Parameters:
>   *  In:
>   *      iobase          - I/O base address
> - *      byContntOffset  - address of EEPROM
> + *      by_contnt_offset  - address of EEPROM

Why did you keep the unneeded "by" prefix?

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ