linux-kernel - Re: linux-next: build failure after merge of the leds-lj tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <85118937-c5fe-8f5c-5033-285f67087f64@denx.de>
Date:   Wed, 9 Aug 2023 14:53:38 +0200
From:   Marek Vasut <marex@...x.de>
To:     Stephen Rothwell <sfr@...b.auug.org.au>, Lee Jones <lee@...nel.org>
Cc:     Isai Gaspar <isaiezequiel.gaspar@....com>, #@...x.de,
        Basically@...x.de, rewrite@...x.de, the@...x.de, driver@...x.de,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the leds-lj tree

On 8/9/23 05:17, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> FATAL: modpost: drivers/leds/leds-pca995x: sizeof(struct i2c_device_id)=32 is not a modulo of the size of section __mod_i2c__<identifier>_device_table=600.
> Fix definition of struct i2c_device_id in mod_devicetable.h
> 
> Presumably caused by commit
> 
>    ee4e80b2962e ("leds: pca995x: Add support for PCA995X chips")
> 
> I have reverted that commit for today.

Ah doh, the fix is trivial, proper patch is coming in a bit.

diff --git a/drivers/leds/leds-pca995x.c b/drivers/leds/leds-pca995x.c
index 3ac99a433fcd2..78215dff14997 100644
--- a/drivers/leds/leds-pca995x.c
+++ b/drivers/leds/leds-pca995x.c
@@ -187,7 +187,7 @@ static const struct of_device_id pca995x_of_match[] = {
         { .compatible = "nxp,pca9955b", .data = (void *)PCA995X_TYPE_B },
         {},
  };
-MODULE_DEVICE_TABLE(i2c, pca995x_of_match);
+MODULE_DEVICE_TABLE(of, pca995x_of_match);

  static struct i2c_driver pca995x_driver = {
         .driver = {