[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABRcYm+24OLedwiLGj1RyvVg22R5NduORVsYZfXSA_OX5F+riA@mail.gmail.com>
Date: Wed, 9 Aug 2023 17:38:00 +0200
From: Florent Revest <revest@...omium.org>
To: Masami Hiramatsu <mhiramat@...nel.org>
Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>,
Steven Rostedt <rostedt@...dmis.org>,
linux-trace-kernel@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>,
Martin KaFai Lau <martin.lau@...ux.dev>,
bpf <bpf@...r.kernel.org>, Sven Schnelle <svens@...ux.ibm.com>,
Alexei Starovoitov <ast@...nel.org>,
Jiri Olsa <jolsa@...nel.org>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Alan Maguire <alan.maguire@...cle.com>,
Mark Rutland <mark.rutland@....com>,
Peter Zijlstra <peterz@...radead.org>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC PATCH v2 4/6] tracing/fprobe: Enable fprobe events with CONFIG_DYNAMIC_FTRACE_WITH_ARGS
On Wed, Aug 9, 2023 at 4:45 PM Masami Hiramatsu <mhiramat@...nel.org> wrote:
> > > --- a/kernel/trace/trace_fprobe.c
> > > +++ b/kernel/trace/trace_fprobe.c
> > > @@ -132,25 +132,30 @@ static int
> > > process_fetch_insn(struct fetch_insn *code, void *rec, void *dest,
> > > void *base)
> > > {
> > > - struct pt_regs *regs = rec;
> > > - unsigned long val;
> > > + struct ftrace_regs *fregs = rec;
> > > + unsigned long val, *stackp;
> > > int ret;
> > >
> > > retry:
> > > /* 1st stage: get value from context */
> > > switch (code->op) {
> > > case FETCH_OP_STACK:
> > > - val = regs_get_kernel_stack_nth(regs, code->param);
> > > + stackp = (unsigned long *)ftrace_regs_get_stack_pointer(fregs);
> > > + if (((unsigned long)(stackp + code->param) & ~(THREAD_SIZE - 1)) ==
> > > + ((unsigned long)stackp & ~(THREAD_SIZE - 1)))
> >
> > Maybe it'd be worth extracting a local
> > "ftrace_regs_get_kernel_stack_nth_addr" helper function and/or
> > "ftrace_regs_within_kernel_stack" ?
>
> Yeah, maybe we can make it a generic inline function in linux/ftrace.h.
Or even just above this function if there are low chances it would get
used elsewhere :)
Powered by blists - more mailing lists