linux-kernel - Re: [PATCH 1/2] dt-bindings: input: cirrus,cs40l50: Support for CS40L50

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2D6A6A19-5EA2-4D2A-A15B-894DA154D616@cirrus.com>
Date:   Wed, 9 Aug 2023 16:41:28 +0000
From:   James Ogletree <James.Ogletree@...rus.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Fred Treven <Fred.Treven@...rus.com>,
        Ben Bright <Ben.Bright@...rus.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Jeff LaBundy <jeff@...undy.com>, Peng Fan <peng.fan@....com>,
        Eddie James <eajames@...ux.ibm.com>,
        Jean Delvare <jdelvare@...e.de>, Arnd Bergmann <arnd@...db.de>,
        Markus Schneider-Pargmann <msp@...libre.com>,
        Jacky Bai <ping.bai@....com>,
        ChiYuan Huang <cy_huang@...htek.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        "patches@...rus.com" <patches@...rus.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: input: cirrus,cs40l50: Support for
 CS40L50


> On Aug 9, 2023, at 1:43 AM, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> 
> On 08/08/2023 19:25, James Ogletree wrote:
> 
>> Signed-off-by: James Ogletree <james.ogletree@...rus.com>
>> ---
>> .../bindings/input/cirrus,cs40l50.yaml        | 77 +++++++++++++++++++
>> MAINTAINERS                                   |  9 +++
>> 2 files changed, 86 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
>> 
>> diff --git a/Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml b/Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
>> new file mode 100644
>> index 000000000000..5437c6beb1b3
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
>> @@ -0,0 +1,77 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/input/cirrus,cs40l50.yaml*__;Iw!!DQ3KfwI!2ioHhI2ig3axVRD-7MYqqT1LF_bitWe1l-B-FQDJfUX_EaTLrLmUnqtyDtEXCVE2cNozj7ODAF7f09JdwmjS9avyHs13Hiw$ 
>> +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!DQ3KfwI!2ioHhI2ig3axVRD-7MYqqT1LF_bitWe1l-B-FQDJfUX_EaTLrLmUnqtyDtEXCVE2cNozj7ODAF7f09JdwmjS9avyeDxRunA$ 
>> +
>> +title: Cirrus Logic CS40L50 Advanced Haptic Driver
> 
> Driver as "motor"? If yes, then ok. If "Linux Driver" then not.

The former, so keeping as-is.

> 
>> +
>> +  cirrus,external-boost:
>> +    description:
>> +      Bypass the CS40L50 boost converter.
>> +
>> +      The amplifier on CS40L50 can be powered internally through the boost
>> +      converter, or else can be powered using an external supply. If an
>> +      external VA supply is used, the boost converter must be bypassed.
>> +    type: boolean
> 
> Isn't this property then conflicting with va-supply?

“VA" was intended to mean amplifier voltage, not analog voltage. I will remove “VA" to fix the ambiguity. 

Best,

James Ogletree